iRex Forum

Matthijs · Posted: Mon Jul 09, 2007 2:06 pm Post subject: Fullscreen mode ipdf

We're contemplating asking the community to develop a fullscreen patch on top of iPDF that can be integrated in the mainstream. Reason is that something like that is already mostly available, but integrating it in its current form is not possible (see spec below).

We'd like to get more interaction with the community and actually get stuff merged back into the mainstream. Problem is: we don't have the time to adapt the currently available stuff to suit our needs and this is why we're asking you guys. I hope you won't take this the wrong way.

Ok, here we go:
Specification would be (different from what is now available from enhanced-ipdf):

1. Toolbar icon to switch to fullscreen
2. Short press of the UP key to exit fullscreen mode

Fullscreen defined as overlapping toolbar and pageBar by setting gtk_window_fullscreen()

We would be providing a patched IPC lib and an icon.

Would this be something you are interested in? Maybe Rincewind would like to create this from his existing patch?

jharker · Joined: 25 Apr 2007 Posts: 281 Location: Rochester, NY, USA

I'd be happy to work on this a little bit. Regarding #2, that change would be trivial, just redefining what button does what. Regarding #1, I don't really know anything about how the toolbar icons are implemented... so it would be great if someone who knows more than me (rincewind? jayk?) could take the lead on that.

Aside from this, what other ipdf improvements are you interested in? The power-saving mods? Some of rincewind's shortcuts? Personally, I find rincewind's quick-erase function absolutely fabulous, and even in the absence of all else, I would advocate including it.

In addition, there are several "bugs" with the hide-the-toolbar patch that need to be addressed. These include:

In fullscreen mode, for some reason the toolbar auto-hides when you toggle continuous mode, even though it is not supposed to (in the code). I don't know why this happens.
In fullscreen mode, the toolbar auto-hides after some other button presses, but I don't recall exactly what. None of these are by design, and we should figure out why that happens.
We need to decide what is proper behavior for the toolbar. For example, should the toolbar auto-hide after "zoom" is selected? After "erase" or "scribble" is selected?
The screen refresh could be slimmed down; in some situations two refreshes are performed in a row; that should be reduced to one.

Also, Matthijs, you said:

realityloop · Joined: 20 Apr 2007 Posts: 54

I'd like to suggest that when in fullscreen mode with the toolbar displayed that any toolbar icon that is selected then auto hides the toolbar, I'd see this as especially relevant behaviour if you have already zoomed your document for best viewing at full screen.

I also agree that quick erase should be part of it, and the powersaving features, though the powersaving features should possibly be an optional setting.

jharker · Joined: 25 Apr 2007 Posts: 281 Location: Rochester, NY, USA

Okay, I realized I had a couple of other questions...

Matthijs · Posted: Tue Jul 10, 2007 7:20 am Post subject:

Powersaving will be done separately in the powerMgr, on a system level. We're still looking at including this in v2.11 (it's lying on the shelf, just have to assess the stability issues if any).

You don't need to modify the toolbar to add an icon, only the IPC lib needs a small change (and the registry). We'll provide the changes for that, so you only need to call the general toolbar icon functions with a new IconID.

The other functions of the enhanced ipdf are just not compatible with our UI and will never be approved by the concept developers for inclusion in a release version.
Shortcut buttons are a big no-no, especially if they are supposed to be assigned to another function (like the up/down arrow and confirm keys).

As for zoom and fullscreen: that is indeed an interesting one... I'm inclined to say that I'd like to at least zoom-to-fit fullscreen when the original one was zoom-to-fit.

So for now I'd like to add fullscreen only.

If deleting all scribbles on a page is to be added, it would need to use a toolbar icon. Maybe we can use the trashcan for that, as the Notes app does...

Zeppy · Joined: 07 Jun 2007 Posts: 37

Matthijs · Posted: Tue Jul 10, 2007 12:24 pm Post subject:

The ideal situation would be that iPDF stores this state inside the manifest.xml. But for now the startup behavior would be to include the toolbar and pageBar (e.g. don't remember the fullscreen state).

realityloop · Joined: 20 Apr 2007 Posts: 54

It would be possible to have the the toolbar collapse sideways to a single icon (or half icon) as a solution to not using shortcut buttons while still gaining maximum screen real estate for reading.

I'd mock up what I'm thinking but I'm unable to find a clean screen grab of iPDF.

If you can link me a clean screenshot I'll happily mock up to show how I'd see the different states looking.

jharker · Joined: 25 Apr 2007 Posts: 281 Location: Rochester, NY, USA

Matthijs,

Ah, that sounds good! Let's see:

Matthijs · Posted: Tue Jul 10, 2007 3:41 pm Post subject:

jharker · Joined: 25 Apr 2007 Posts: 281 Location: Rochester, NY, USA

Oh- whoops, no, you're right. I forgot that A4 pages have a taller form-factor than the iLiad screen. Also Letter pages, I think. Yes, you're right, that would be a problem for many standard pages and should be fixed / changed.

tribble · Joined: 04 Aug 2006 Posts: 645 Location: Bonn, Germany

I would like to see, that if you are zoomed in, the toggling between fullscreen and normal should also fit the zoom area to the maximum in the available screenspace.

rincewind · Joined: 10 Jan 2007 Posts: 177 Location: Norway

jharker · Joined: 25 Apr 2007 Posts: 281 Location: Rochester, NY, USA

Hiya!

Well, as you may have guessed from my other posts, I'm back from my long hiatus and have a little time to spend on projects like the fullscreen patch. Over the next few days I'm going to try to develop a list of exact specifications for the patch's functionality. Then I'll sit down and code it, then debug it. Depending on what "real" work comes my way, I figure it'll take about a week, maybe two.

In the meantime, if anyone has suggestions or comments, now's the time to bring it up!

Matthijs, eventually we'll need that modified toolbar, or at least I'll need to know how you'll reference the new toolbar button in the software. In the meantime, I'll make an unused button (long down arrow?) do the job of the toolbar button, and when the new toolbar is ready I'll just move the code.

kusmi · Posted: Fri Feb 15, 2008 9:50 pm Post subject:

I remember installing an pre-version of this one on my iLiad and it seemed usable, but have not seen it appearing in the mainstream release from iRex - is there still work to be done before integrating it into the "real" software release?